I noticed that C consumer will always lose messages in failure modes #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann and
andreleblanc11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because the C consumer library acknowledges messages ... so the application layer cannot.
When we test failures (but restarting sarracenia, or the broker) the C consumer (aka sr3_cpump) is likely to lose messages. The C consumer is not currently used operationally anywhere, it's more of a demonstrator (can replace a shovel or a winnow) but with the caveat from that it doesn't deal with failure well:
MetPX/sarrac#121
So remove the tests that require C consumer to be 100% reliable, and the flow tests should pass more often.