Add fix to handle improperly parsed station names from getStation #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersilva
approved these changes
Mar 8, 2024
petersilva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawned from my audit script.
It saw a bulletin , a
UECN99, crashing sr3 on the new NCP servers. Turns out thegetStationmethod insidesarracenia/bulletin.pyis technically wrong and Sundew has a way of handling these errors better than sr3.I added a fix where we only want alphanumeric data to pass through for the station (3 to 5 characters). This fixes this issue but its possible that other non-valid alphanumeric stations pass through. Only time will tell.
FYI : The Sundew way of handling the error could not be found.