Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue918 - Add plugin to rename AM bulletins properly #933

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

andreleblanc11
Copy link
Member

Couple of things to note for this new plugin.

  • The plugin looks for bulletins with 2 characters as its header in the filename. If that is not found, the bulletin remains untouched. If it is found, we add all the necessary data to the filename.
  • I added the new directory flowcb/rename to accomodate for the function of the plugin.
  • I'll be looking at delegating Sundew derived methods, i.e. getStation, getBBB, buildHeader, getTime, to a parent class as they might be useful for future plugins. Will do this in a separate PR

I've been testing the plugin for the last couple of hours on dev and it's been working well.

One thing to note is that the AM receiver still doesn't append the timestamp inside the bulletin. I'm waiting to add this with the parent class PR.

Copy link
Contributor

@petersilva petersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go. since no tests will fail, and you are the only one running AM to be able to test it, there is no reason to refuse the PR. I especially like that you have sample inputs and outputs in comments in the code. It makes it much more intelligible for whoever has to modify this in a decade.

@andreleblanc11
Copy link
Member Author

I added another commit so that erroneous bulletins get better handled.

Previously, sr3 would just post the erroneous bulletins downstream. Sundew will add the file to a PROBLEM directory so that the files don't get ingested by senders.

What I did is I added the message to worklist.rejected and I write out the file with _PROBLEM at the suffix and with a fresh timestamp. In this case, we'll have clear records of bulletins that have failed.

@petersilva petersilva merged commit 9da9947 into development Feb 14, 2024
4 checks passed
@petersilva petersilva deleted the issue918 branch March 24, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants