Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V03 issue721 - fix so filetype detection is now an optional extra #734

Closed
wants to merge 11 commits into from

Commits on Jun 27, 2023

  1. inrement away from previous release

    petersilva committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    910ab55 View commit details
    Browse the repository at this point in the history
  2. Fix for cases where downloaded file size is different than expected. …

    …For #709 (#710)
    
    When a file was downloaded successfully, but the size was different than in the message, or the message didn't include a file size, still rename the file and patch content_type.
    reidsunderland authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    2d943ca View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Configuration menu
    Copy the full SHA
    2bfc089 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Resolves issue #712 (#713)

    Thanks very much!
    Elhossein authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    bd9d3ff View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Configuration menu
    Copy the full SHA
    329cd83 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Merge pull request #719 from MetPX/v03_undeclared_whine_once into v03…

    …_WIP
    
    "possibly undeclared" option message should only be printed once.
    andreleblanc11 authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    0762763 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Fix a couple of problems in init (#727)

    These were found when developing unit tests
    gcglinton authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    b375512 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Sarracenia __init__ unit test (#730)

    * New sarracenia init tests
    
    * Add pytest-mock requirement for unit tests
    
    * Sarracenia init unit test
    
    This has about 90% coverage
    
    * Update tests README with extra info on config
    
    Debugging tests wasn't working, and it's because generating code coverage while debugging breaks debugging.
    
    * Add try/except around init tests that use xattr module
    
    Apparently it's not a standard module everywhere, so this is a workaround
    Could also juse use SR3's filemetadata methods, as they handle things "nicely"
    gcglinton authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    e401ab3 View commit details
    Browse the repository at this point in the history
  2. Update unit testing patterns (#731)

    * Expand test debugging (pretty)
    
    Pretty printing wasn't awesome, but now it's better.
    
    * Move Options into a proper class
    
    * Move message creation into method
    
    This ensures that there's no collisions between tests if we modify properties/dict values
    
    * Use deepcopy on WorkList creation in each test
    
    This ensures that they're always unique, and have no collisions between tests
    
    * Fix broken retry tests
    
    * Add Note to top of retry "steps" test
    
    It's disabled, but can serve as good documentation of how to do it.
    
    * Capture test log existance, and assert against that
    
    It used to assert inside the "if" statement, but that would only ever be True. This way, it would be possible for the logs to be missing, and the test will fail.
    
    * Fix redisqueue cleanup test
    
    No longer need to specify a fake server, becasue we're checking the keys a little more inteligently.
    
    * Clean up commented code
    
    * Expand test debugging (pretty)
    
    Pretty printing wasn't awesome, but now it's better.
    
    * Move Options into a proper class
    
    * Move message creation into method
    
    This ensures that there's no collisions between tests if we modify properties/dict values
    
    * Use deepcopy on WorkList creation in each test
    
    This ensures that they're always unique, and have no collisions between tests
    
    * Fix broken retry tests
    
    * Add Note to top of retry "steps" test
    
    It's disabled, but can serve as good documentation of how to do it.
    
    * Capture test log existance, and assert against that
    
    It used to assert inside the "if" statement, but that would only ever be True. This way, it would be possible for the logs to be missing, and the test will fail.
    
    * Fix redisqueue cleanup test
    
    No longer need to specify a fake server, becasue we're checking the keys a little more inteligently.
    
    * Clean up commented code
    gcglinton authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    10d730a View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. issue #721 make magic an extra, degrade gracefully when missing.

    Also added *all* extra to install all extras.
    petersilva committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    ddbd669 View commit details
    Browse the repository at this point in the history
  2. updating documentation for #721, new filetypes extra.

    documenting recent changes (optional filetypes extra) and recent
    both languages.
    petersilva committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    2ce3a33 View commit details
    Browse the repository at this point in the history