V03 issue643 - on_cleanup now works (needed by redisqueue ) #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
establishment to complete.
corrected with new topicDerive in postformat parent class, same for v02, and v03.
selected. disabling.
events. also fixes a problem introduced by previous branch where cleanup was broken because xxxSetup routines were no longer called by init
petersilva
changed the title
petersilva
requested review from
reidsunderland,
alexandreleroux,
MagikEh and
tysonkaufmann
|
@gcglinton might want to try this branch out, and see if the cleanup works on his redis stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the previous two pull requests, fixing issue #643 by adding event callbacks
for on_cleanup, on_declare, and on_sanity. The on_cleanup is needed by redisqueue
stuff to ensure that resources allocated on a redisqueue can be cleaned out.
Also noticed that the previous work to enable this, had broken cleanup
as there was no call to xxxSetup()