-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unit testing patterns #731
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty printing wasn't awesome, but now it's better.
This ensures that there's no collisions between tests if we modify properties/dict values
This ensures that they're always unique, and have no collisions between tests
It's disabled, but can serve as good documentation of how to do it.
It used to assert inside the "if" statement, but that would only ever be True. This way, it would be possible for the logs to be missing, and the test will fail.
No longer need to specify a fake server, becasue we're checking the keys a little more inteligently.
Pretty printing wasn't awesome, but now it's better.
This ensures that there's no collisions between tests if we modify properties/dict values
This ensures that they're always unique, and have no collisions between tests
It's disabled, but can serve as good documentation of how to do it.
It used to assert inside the "if" statement, but that would only ever be True. This way, it would be possible for the logs to be missing, and the test will fail.
No longer need to specify a fake server, becasue we're checking the keys a little more inteligently.
… into UpdateTesting
There's so many commits here, but really there's a bunch of duplication. No idea how to fix that... |
will do a squash merge... number of commits not an issue then... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In writing more and more tests, some things have been streamlined, or improved, and this is just back-porting those changes to previous tests.
pretty
method that you can use while debugging your restspretty(ThingYouWantToDump)
, then run your tests with-vv
and--capture=tee-sys
parametersOptions
andMessage
creation into methods (versus creating objects manually)sarracenia.config.default_config()
to generate base configdeepcopy
instead of just straight copy, so tests don't affect eachotherrety_test.py
, so fix thoseretry_teststeps.py
about how it works, and why we're not using it for our testsif
block, so they could never fail; Fixed that