V03 issue415 #723
Merged
V03 issue415 #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
establishment to complete.
corrected with new topicDerive in postformat parent class, same for v02, and v03.
selected. disabling.
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann and
andreleblanc11
|
All the MQTT stuff works... dunno what is going on with redis but this is way more positive tests than any branch before it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #415, adding support for mqtt over websockets (changes connect verb in use of paho-mqtt library) This is done by adding w or ws to the broker URL (mqtt:// is pure mqtt protocol, mqttws:// is mqtt over websockets (using SSL))
Also noticed why the flow tests were failing for MQTT, there was a mistake in handling of exchangeSplit, fixed in this branch. MQTT might completely work after this is merged.