Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves issue #712 #713

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Resolves issue #712 #713

merged 1 commit into from
Jul 6, 2023

Conversation

Elhossein
Copy link
Contributor

Added an if statement to check if str_value is not a string

Previously, the code only checked for None as a string. Now it checks for None as a NoneType by making sure str_value is a str type. This could've been implemented by
if str_value == None:
return 0
However, checking that str_value is not a string covers more cases.

@reidsunderland reidsunderland changed the base branch from main to v03_wip July 5, 2023 20:30
@reidsunderland
Copy link
Member

I changed the base branch to v03_wip. But it looks good to me. Thank you @Elhossein

@petersilva petersilva merged commit bd9d3ff into MetPX:v03_wip Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants