Fix #709 - properly handle downloaded files with size mismatches #710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in #709.
Before this change, files would only get renamed from their inflight name (e.g. filename.ext.tmp) when the downloaded size matched the expected size in the message.
When there is no size in the message, or the downloaded size is different, the files would not be renamed from their inflight name and later parts of the code would fail.
This ensures that the file gets renamed properly (and contentType gets set) when downloads are successful but the size is different than expected.