V03 issue703 #706
Merged
V03 issue703 #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersilva
requested review from
MagikEh,
reidsunderland,
tysonkaufmann and
andreleblanc11
|
metpx-sr3 support implemented in this: 929b6f7d81835a0395162045ab1df6d15b4aa0c6 |
petersilva
added a commit
that referenced
this pull request
Jun 21, 2023
* Added many more NoDupe tests * Add final tests to nodupe * Add nodupe sub-class tests * Created nodupe_redis Stripped a lot of the methods out, because they just aren't needed with Redis. * First try at Redis Nodupe * Unit test for nodupe_redis * Merged nodupe derivekey tests into 1 Previously had a whole bunch of them, but since we're re-instanciating the message for each derivation, they can all go in one. * Unit test for nodupe_redis Had to make some changes to the module itself because some functionality wasn't working * Create generic nodupe unit test Trying to compare the functionality of the disk-, and redis-based nodupe classes is going to be hard. Most (all?) of the methods don't actually return anything, and if we're assuming to abstract the inner workings of each one, there's nothing to validate they're doing the same thing. * Delete individual derivekey nodupe unit tests * Add test docs on using VSCode * Allow picking which driver to use for NoDupe * Add missing config options for redis nodupe * Fix cache size counting I'm not sure how much any of this counting matters, or if it's just for logging purposes. Either way.. it's better now. * Fix broken nodupe.redis tests * Change field delimiter in nodupe redis key * Update redis key field delimiter in nodupe test * Fixed mis-named config option Nodupe Redis was using retryqueue server URL. now it's not. * Standardized some testing aspects - Made the add_option method for options work properly - Added PrettyPrinter code for debugging tests * Clean-up test debugging code * Make Redis Nodupe count better It wasn't loading on_start, or clearning on_stop, so it was never accurate. I still don't really think it's all that accurate but since it's just for logging purposes, it might not need to be better than it is. * Disabled uneeded redis Retry test * Update retry unit test dependencies Used to have dependencies per method, but now the comparative tests depend on both driver tests. This ensures that nothing gets missed. * Comparative NoDupe unit test Compares state/output of both Disk and Redis nodupe drivers against an expected value. * Change integrity to identity, per #703 and #706 This might cause merge conflicts, but it's probably still worth changing here. * Resolve config.py conflict * Resolve second config.py conflict --------- Co-authored-by: Peter Silva <[email protected]>
* Added many more NoDupe tests * Add final tests to nodupe * Add nodupe sub-class tests * Created nodupe_redis Stripped a lot of the methods out, because they just aren't needed with Redis. * First try at Redis Nodupe * Unit test for nodupe_redis * Merged nodupe derivekey tests into 1 Previously had a whole bunch of them, but since we're re-instanciating the message for each derivation, they can all go in one. * Unit test for nodupe_redis Had to make some changes to the module itself because some functionality wasn't working * Create generic nodupe unit test Trying to compare the functionality of the disk-, and redis-based nodupe classes is going to be hard. Most (all?) of the methods don't actually return anything, and if we're assuming to abstract the inner workings of each one, there's nothing to validate they're doing the same thing. * Delete individual derivekey nodupe unit tests * Add test docs on using VSCode * Allow picking which driver to use for NoDupe * Add missing config options for redis nodupe * Fix cache size counting I'm not sure how much any of this counting matters, or if it's just for logging purposes. Either way.. it's better now. * Fix broken nodupe.redis tests * Change field delimiter in nodupe redis key * Update redis key field delimiter in nodupe test * Fixed mis-named config option Nodupe Redis was using retryqueue server URL. now it's not. * Standardized some testing aspects - Made the add_option method for options work properly - Added PrettyPrinter code for debugging tests * Clean-up test debugging code * Make Redis Nodupe count better It wasn't loading on_start, or clearning on_stop, so it was never accurate. I still don't really think it's all that accurate but since it's just for logging purposes, it might not need to be better than it is. * Disabled uneeded redis Retry test * Update retry unit test dependencies Used to have dependencies per method, but now the comparative tests depend on both driver tests. This ensures that nothing gets missed. * Comparative NoDupe unit test Compares state/output of both Disk and Redis nodupe drivers against an expected value. * Change integrity to identity, per #703 and #706 This might cause merge conflicts, but it's probably still worth changing here. * Resolve config.py conflict * Resolve second config.py conflict --------- Co-authored-by: Peter Silva <[email protected]>
reidsunderland
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changing v03 format message "integrity" field to "identity" for sr3. issue #703
There need to be matching pull requests for v2, and metpx-sr3c.