Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodupe unit tests #697

Merged
merged 5 commits into from
Jun 19, 2023
Merged

Nodupe unit tests #697

merged 5 commits into from
Jun 19, 2023

Conversation

gcglinton
Copy link
Contributor

Unit tests for all modules, and methods in flowcb/nodupe

  • __init__.py has 94% coverage; there's two methods that are never used, so they're not tested
  • name.py has 100% coverage
  • data.py has 100% coverage
#pytest tests/sarracenia/flowcb/nodupe/
========================================= test session starts ==========================================
platform linux -- Python 3.9.14, pytest-7.3.1, pluggy-1.0.0
rootdir: /home/me/code/HPCDatamart/fork/tests
configfile: pytest.ini
plugins: metadata-3.0.0, depends-1.0.1, cov-4.1.0, bug-1.2.0, html-3.2.0
collected 26 items                                                                                     

tests/sarracenia/flowcb/nodupe/__init___test.py ........                                         [ 30%]
tests/sarracenia/flowcb/nodupe/data_test.py .                                                    [ 34%]
tests/sarracenia/flowcb/nodupe/name_test.py .                                                    [ 38%]
tests/sarracenia/flowcb/nodupe/__init___test.py ................                                 [100%]

========================================== 26 passed in 0.16s ==========================================

@petersilva
Copy link
Contributor

what are the two methods that "aren't called" ?

@gcglinton
Copy link
Contributor Author

It's delete_path, and free.

@gcglinton
Copy link
Contributor Author

I did a quick test, and deleting those methods yields 99% coverage.

@petersilva petersilva merged commit ef68615 into MetPX:v03_wip Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants