Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation correction for #677 #683

Merged
merged 2 commits into from
May 26, 2023
Merged

documentation correction for #677 #683

merged 2 commits into from
May 26, 2023

Conversation

petersilva
Copy link
Contributor

See #677

@petersilva
Copy link
Contributor Author

had created pull vs. main... which was wrong...

MagikEh
MagikEh requested changes May 26, 2023
View reviewed changes
Copy link
Contributor

@MagikEh MagikEh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One can create an bulletin

needs to be changed to

One can create a bulletin

Also, I wonder about the appending to data-ingest.conf rather than overwriting it? Will there be issues with defining two brokers and topicPrefix's in a single config?

@petersilva
Copy link
Contributor Author

@MagikEh good points, added a patch.

@MagikEh MagikEh merged commit d3e3f74 into v03_wip May 26, 2023
@MagikEh MagikEh deleted the v03_issue677 branch May 26, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MagikEh MagikEh MagikEh requested changes

Assignees

@reidsunderland reidsunderland

@kurt2x kurt2x

@MagikEh MagikEh

@tysonkaufmann tysonkaufmann

@junhu3 junhu3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petersilva @MagikEh @reidsunderland @kurt2x @tysonkaufmann @junhu3