fix rejectPercent maybe other stuff? #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann and
andreleblanc11
Test Results247 tests 245 ✅ 1m 33s ⏱️ For more details on these failures, see this check. Results for commit 6f53028. ♻️ This comment has been updated with latest results. |
|
second patch changes "lag from 595483.20s to 6d21h" ... e.g: becomes: so it does not upset the columns that way either. |
|
I just noticed my fancy formatting has a problem... I made a conversion routine to make like 3h4m (3 hours and 4 minutes) but I didn't do the reverse conversion, which is needed. another commit coming. |
|
fixed now. |
reidsunderland
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@reidsunderland noticed a metric calculation that is off.
Now that people can see the metrics on real deployments, problems should be a lot more obvious. it might be worthwhile rooting around to see if other problems are detected.
We can maybe catch a couple with this PR.