Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1173: problems stopping instances #1178

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Fix #1173: problems stopping instances #1178

merged 6 commits into from
Aug 22, 2024

Commits on Aug 21, 2024

  1. First attempt to fix #1173 by removing signal handler from Moth classes

    @reidsunderland
    reidsunderland committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    fefec16 View commit details
    Browse the repository at this point in the history

  2. fix typo

    @reidsunderland
    reidsunderland committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    722a2b4 View commit details
    Browse the repository at this point in the history

  3. flowcb please_stop method was not being called in most cases

    @reidsunderland
    reidsunderland committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    76e53f1 View commit details
    Browse the repository at this point in the history

  4. Implement interruptible_sleep that can be interrupted by a signal; re… 

    …factor stop/signal handling routines
    @reidsunderland
    reidsunderland committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    302cd98 View commit details
    Browse the repository at this point in the history

  5. Fix typo noticed by linter

    @reidsunderland
    reidsunderland committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    e6b1770 View commit details
    Browse the repository at this point in the history

  6. Add comments to explain cases where the flow loop will shut itself down. 

    I've worked on this code before and it still took me a long time to
re-figure out why it was doing that.
    @reidsunderland
    reidsunderland committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    56d2be7 View commit details
    Browse the repository at this point in the history