#1167 fix clash in class names with a directory prefix. inelegant, bu… #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann,
andreleblanc11,
mshak2 and
gcglinton
Test Results246 tests 245 ✅ 1m 6s ⏱️ Results for commit dfb2f82. ♻️ This comment has been updated with latest results. |
|
My convention was to use double underscores between the directory and file name elements, as some of the classes/files have underscores in them, and this provides a bit of extra clarity about the first element being "different". In this case: That said, this works perfectly well, and this suggestion is just a small nit-pick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1167
As per advice from @gcglinton ... tried it... it works... way easier than finding anything else.