Issue1159 #1162
Merged
Issue1159 #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersilva
requested review from
reidsunderland,
MagikEh,
iMacadan,
tysonkaufmann,
andreleblanc11 and
mshak2
Test Results1 tests 0 ✅ 14s ⏱️ For more details on these errors, see this check. Results for commit 1b9b89b. |
|
ohh... it's only the cleanups that fail... so the other PR is needed, to do cleanups.. but the flow tests do not check if the cleanup succeeds. That's why stuff is passing. |
reidsunderland
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1159
give the kinds of error messages normal people expect when invalid configurations (usualyl typos) are given on the command line. If given a configuration that does not match anything... be conservative and do nothing.
Note, the flow tests currently do operations on non-existent/invalid configurations, so they need a PR ...
this one: MetPX/sr_insects#54
in order to pass (the flow tests when automatically invoked below will fail because the above sr_insects PR isn't merged.)