Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #953 re-enable and fix passive queue declare #1160

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

reidsunderland
Copy link
Member

Re-enables the passive queue declare that we use to get the number of messages in the queue.

#953 is fixed by only calling self.__connect from _queueDeclare when it's necessary. If we're already connected, connecting again will cause problems.

…eclare to get number of messages in queue
Copy link

github-actions bot commented Aug 9, 2024

Test Results

1 tests   0 ✅  14s ⏱️
1 suites  0 💤
1 files    0 ❌  1 🔥

For more details on these errors, see this check.

Results for commit ff6a770.

Copy link
Contributor

@petersilva petersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very likely correct. I hope this fixes things... doing it early in the release cycle (for after 54) will give us time to validate that it's really solid. The old one seemed fine in the flow tests, but blew up in use.

@petersilva petersilva merged commit d387893 into development Aug 9, 2024
30 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants