Fix #1151 #1152
Merged
Fix #1151 #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results1 tests 0 ✅ 14s ⏱️ For more details on these errors, see this check. Results for commit 9c580d5. ♻️ This comment has been updated with latest results. |
petersilva
requested changes
Aug 7, 2024
There was a problem hiding this comment.
this patch does not make sense. why would a routine return 'null' as a string? looking at the source of the other routine, it returns either the value or python None.
This code effectively disables every reading the extended attributes because the return value never == 'null'.
…o computeIdentity
petersilva
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
identityis missing fromxattrit returns anullstring