Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the NASA CMR plugin, bug when using the other data source #1123

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

reidsunderland
Copy link
Member

When using dataSource other, if relatedUrl_descriptionContains and/or relatedUrl_urlContains were not set, it would crash. It would also crash if the a relatedUrl did not contain a description like these:

                "RelatedUrls": [
                    {
                        "URL": "https://n5eil01u.ecs.nsidc.org/DP4/SMAP/SPL1BTB_NRT.105/2024.06.07/SMAP_L1B_TB_NRT_49945_D_20240607T143459_N17701_002.h5",
                        "Type": "GET DATA",
                        "MimeType": "application/x-hdfeos"
                    },
                    {
                        "URL": "https://n5eil01u.ecs.nsidc.org/DP1/AMSA/QA.001/2024.06.07/SMAP_L1B_TB_NRT_49945_D_20240607T143459_N17701_002.qa",
                        "Type": "VIEW RELATED INFORMATION",
                        "MimeType": "text/plain"
                    },
                    {
                        "URL": "https://n5eil01u.ecs.nsidc.org/DP4/SMAP/SPL1BTB_NRT.105/2024.06.07/SMAP_L1B_TB_NRT_49945_D_20240607T143459_N17701_002.h5.iso.xml",
                        "Type": "VIEW RELATED INFORMATION",
                        "MimeType": "text/xml"
                    }
                ],

I also renamed it, because the old name Poll_NASA_CMR was redundant. It's in the poll directory.

Copy link

github-actions bot commented Jun 25, 2024

Test Results

1 tests   0 ✅  13s ⏱️
1 suites  0 💤
1 files    0 ❌  1 🔥

For more details on these errors, see this check.

Results for commit f00fafa.

♻️ This comment has been updated with latest results.

@andreleblanc11
Copy link
Member

andreleblanc11 commented Jun 25, 2024

FYI @gcglinton put base unit tests for all flowcbs. It looks like the one for NASA CMR is failing now due to the name change

@reidsunderland reidsunderland merged commit ea7d82d into development Jun 26, 2024
2 of 4 checks passed
@reidsunderland
Copy link
Member Author

oops I didn't notice the comment about unit tests before I clicked merge. I'll fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants