Paho mqtt v2 support #1119
Merged
Paho mqtt v2 support #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
over the winter the exchangeFromSource and exchangeFromMirror and some topic settings were added on the amqp side. Support for these was absent in mqtt, and it's pretty much identical, so moved the implementation to the sarracenia.Message class, and can now call deriveSource() and deriveTopics() from both amqp and mqtt implementations.
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann,
andreleblanc11 and
mshak2
Test Results244 tests 242 ✅ 1m 0s ⏱️ For more details on these failures, see this check. Results for commit 9738569. ♻️ This comment has been updated with latest results. |
reidsunderland
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch changes the mqtt driver to use version 2.1 of paho-mqtt python client... the current one (released in 2024.)
Previous versions have no way of passing the flakey_broker test, and will fail in other ways because there
it no application control of acknowledgements. The patch I submitted to the paho-mqtt for application acknowledgements was only merged for v2. V2 also brings many api changes, so it's not straight-forward.
The stack, as-is, passes more tests than the old mqtt support did on the old mqtt version, but not yet all tests.
It's still better than what is there, and will probably not come back to it for a while, so better not to have a long running parallel branch.
It will be a good basis for finishing the work later.
This is part of #693 ... it might actually solve flakey... but there might be some timing issues... (false positives, where the results seem ok,. but the test indicates a failure.)