Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1115 stopped flows were marked cpuS. fix #1116

Merged
merged 2 commits into from
Jun 19, 2024
Merged

#1115 stopped flows were marked cpuS. fix #1116

merged 2 commits into from
Jun 19, 2024

Conversation

petersilva
Copy link
Contributor

@petersilva petersilva commented Jun 19, 2024 •
edited
Loading

  • the cpuS check was a guard that was independent of the other running states... but it is a running state... something needs to be running for it to apply. cpuS check was using metrics file to override the stopped state, so it thought stuff was running slow, when it was not running at all.

fix is explicit guard... only check for cpuS if there is something running.

@petersilva petersilva marked this pull request as ready for review June 19, 2024 20:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

Test Results

244 tests   243 ✅  1m 0s ⏱️
  1 suites    1 💤
  1 files      0 ❌

Results for commit d7b2de5.

♻️ This comment has been updated with latest results.

@petersilva petersilva merged commit be1ad27 into development Jun 19, 2024
4 checks passed
@petersilva petersilva deleted the issue1115 branch August 9, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidsunderland reidsunderland reidsunderland approved these changes

@MagikEh MagikEh Awaiting requested review from MagikEh

@tysonkaufmann tysonkaufmann Awaiting requested review from tysonkaufmann

@andreleblanc11 andreleblanc11 Awaiting requested review from andreleblanc11

@mshak2 mshak2 Awaiting requested review from mshak2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@petersilva @reidsunderland