Random fixes #1103
Merged
Random fixes #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin was written before directories were in messages, and was assigning directories the .txt suffix... have it not try to put a type suffix on directories. Also, the way file renames are represented is different. updated that code as well.
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann and
andreleblanc11
Test Results243 tests 242 ✅ 1m 6s ⏱️ Results for commit 5b94f56. ♻️ This comment has been updated with latest results. |
…l make unit tests pass again
This reverts commit a79d460. Reid already has some other fix.
reidsunderland
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on some flow_tests that do not currently work and noticed a bunch of things. Also:
This is still a work in progress, might add some more. don't review yet.