Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only run after_post after we actually post #1101

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

petersilva
Copy link
Contributor

close #1066

kind of obvious.

Copy link

github-actions bot commented Jun 6, 2024

Test Results

242 tests   234 ✅  18s ⏱️
  1 suites    8 💤
  1 files      0 ❌

Results for commit d31c610.

Copy link
Member

@reidsunderland reidsunderland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It's a draft, so maybe i wasn't supposed to review it yet

@petersilva petersilva marked this pull request as ready for review June 6, 2024 20:53
@petersilva petersilva merged commit 590e591 into development Jun 6, 2024
28 of 35 checks passed
@petersilva petersilva deleted the issue1066 branch June 6, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after_post runs even though nothing has been posted
2 participants