Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1089 fileAgeMin and fileAgeMax should be honoured by all components #1100

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Issue1089 fileAgeMin and fileAgeMax should be honoured by all components #1100

merged 2 commits into from
Jun 6, 2024

Conversation

petersilva
Copy link
Contributor

closes #1089

  • put a check in flow/init.py/ filter() routine... which is used by all components.
  • files that are too old, are rejected (permanently dropped.)
  • files that are too youn, are failed, which should result in them being put on the retry list for later.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Test Results

242 tests   234 ✅  18s ⏱️
  1 suites    8 💤
  1 files      0 ❌

Results for commit d028e93.

@petersilva petersilva changed the title Issue1089 Issue1089 fileAgeMin and fileAgeMax should be honoured by all components Jun 6, 2024
@petersilva petersilva marked this pull request as ready for review June 6, 2024 20:53
reidsunderland
reidsunderland approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@reidsunderland reidsunderland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good, thanks!

I see self.o.messageAgeMax/Min, they're not documented. Are they supposed to be user configurable options?

@petersilva petersilva merged commit 2a28e91 into development Jun 6, 2024
52 of 67 checks passed
@petersilva petersilva deleted the issue1089 branch June 6, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidsunderland reidsunderland reidsunderland approved these changes

@MagikEh MagikEh Awaiting requested review from MagikEh

@tysonkaufmann tysonkaufmann Awaiting requested review from tysonkaufmann

@andreleblanc11 andreleblanc11 Awaiting requested review from andreleblanc11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fileAgeMax doesn't work in all situations?
2 participants
@petersilva @reidsunderland