Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directory to send, etc. errors #1099

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Add directory to send, etc. errors #1099

merged 2 commits into from
Jun 6, 2024

Conversation

reidsunderland
Copy link
Member

Closes #1098. Sorry to steal this from @mshak2, i was trying to debug errors on dev and it was super hard without this.

Creating as a draft, because I need to make sure the flow tests pass.

Copy link

github-actions bot commented Jun 6, 2024

Test Results

242 tests   234 ✅  19s ⏱️
  1 suites    8 💤
  1 files      0 ❌

Results for commit d21fe2e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@petersilva petersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should make these messages more verbose... as in list both source and destination, and username and host... my original thinking in not having this was that it is all available on other lines in the log, and so I would just use the grep to find the error and use either vi or grep -B10 -A10 to get the other information. But I see it's a lot easier to get everything we need if a straight grep will do it... so maybe the error messages should be a lot more explicit. not sure...

@reidsunderland
Copy link
Member Author

reidsunderland commented Jun 6, 2024

I think that would be great, have all the information in one place. It would make troubleshooting a lot easier.

Especially with batching, the lines immediately above and below don't always have the needed information.

@petersilva petersilva marked this pull request as ready for review June 6, 2024 20:15
@petersilva petersilva merged commit cbfa0fe into development Jun 6, 2024
4 checks passed
@petersilva petersilva deleted the issue1098 branch June 6, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sender IO errors don't show paths
2 participants