Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc feedback #1094

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Doc feedback #1094

merged 6 commits into from
Jun 6, 2024

Conversation

petersilva
Copy link
Contributor

@petersilva petersilva commented Jun 5, 2024 •
edited
Loading

feedback from discussions this morning:

  • logFormat should work after this is merged.
  • some messages demoted from info to debug.
  • other messages demoted to oblivion.
  • set option documented.

@petersilva
adding logFormat formal definition
acb408f 
adding definition as str_option because unless type is given,
it defaults to a list, which does not work properly.
@petersilva
document set, other small fixes
49a7eba
@petersilva
demoting more messages to de-clutter info
3a96e81
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024 •
edited
Loading

Test Results

242 tests   234 ✅  17s ⏱️
  1 suites    8 💤
  1 files      0 ❌

Results for commit 8047e8b.

♻️ This comment has been updated with latest results.

@petersilva
Copy link
Contributor Author

the logFormat stuff still does not work... that's probably why it is not documented... I think I messed with it for a while, but the programmable log format does not work.

@petersilva
Copy link
Contributor Author

for clarity... I don't know how to fix the logFormat thing... don't plan on working on it further... this PR improves things regardless.

reidsunderland
reidsunderland approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@reidsunderland reidsunderland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the RateMax log messages - i upgraded the message that says when it's throttling back to INFO. And downgraded a different message (that prints the current rate vs ratemax) down to DEBUG.

And French translation, from @andreleblanc11 / Google

@petersilva
Copy link
Contributor Author

I fixed the logFormatting after all...

@petersilva petersilva marked this pull request as ready for review June 6, 2024 14:41
@petersilva petersilva merged commit 3211eff into development Jun 6, 2024
4 checks passed
@petersilva petersilva deleted the doc_feedback branch June 6, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidsunderland reidsunderland reidsunderland approved these changes

@MagikEh MagikEh Awaiting requested review from MagikEh

@tysonkaufmann tysonkaufmann Awaiting requested review from tysonkaufmann

@andreleblanc11 andreleblanc11 Awaiting requested review from andreleblanc11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petersilva @reidsunderland