-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc feedback #1094
Doc feedback #1094
Conversation
adding definition as str_option because unless type is given, it defaults to a list, which does not work properly.
Test Results242 tests 234 ✅ 17s ⏱️ Results for commit 8047e8b. ♻️ This comment has been updated with latest results. |
the logFormat stuff still does not work... that's probably why it is not documented... I think I messed with it for a while, but the programmable log format does not work. |
for clarity... I don't know how to fix the logFormat thing... don't plan on working on it further... this PR improves things regardless. |
…ateMax log levels
c4eb164
to
2646de7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the RateMax log messages - i upgraded the message that says when it's throttling back to INFO. And downgraded a different message (that prints the current rate vs ratemax) down to DEBUG.
And French translation, from @andreleblanc11 / Google
I fixed the logFormatting after all... |
feedback from discussions this morning: