Issue1035 retry too much, reduce cpu to some extent... #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann and
andreleblanc11
Test Results242 tests 234 ✅ 19s ⏱️ Results for commit 409f3eb. ♻️ This comment has been updated with latest results. |
|
Even if this doesn't fix the main load problem, it should still help drag it down at least a bit. After we merge to |
andreleblanc11
approved these changes
Jun 4, 2024
|
I think the basic test was failing because the metrics dir was not being created in one case. Re-added to beginnning of run() routine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves #1035 hopefully.
trying to reduce cpu time usage. It creeps up after having run for a long time. Not sure if this fixes it, but it should help.
So this eliminates all file i/o in the main run loop. there will be no i/o if:
eliminated a lot of file i/o noise for checks for directory existence also.
We'll see how much this helps. It does help... but the extent is unclear.