remove plugins that are useless and will not run. #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the tolocal.py expects a message field "urlstr" to be present in the message, which isn't there in v3. so it will just crash if you try to use it. We could fix it, but what does it do? It converts a web url to a local file url... We already have working tolocalfile.py which does that. The only "advantage" of tolocal is that it has a paired callback "tohttp.py" but that just does what an ordinary *post_baseURl* setting will do in sr3. so tohttp.py is useless, tofile.py doesn't work and there is an existing working implementation anyways... so... bye...
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann,
andreleblanc11 and
mshak2
Test Results2 tests 0 ✅ 14s ⏱️ For more details on these errors, see this check. Results for commit e21f077. |
andreleblanc11
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the tolocal.py expects a message field "urlstr" to be present in the message, which isn't there in v3. so it will just crash if you try to use it. We could fix it, but what does it do? It converts a web url to a local file url...
We already have working tolocalfile.py which does that. The only "advantage" of tolocal is that it has a paired callback "tohttp.py" but that just does what an ordinary post_baseURl setting will do in sr3. so tohttp.py is useless, tofile.py doesn't work and there is an existing working implementation anyways... so... bye...