-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sanity not starting missing instances #1053
Conversation
Test Results220 tests 212 ✅ 16s ⏱️ Results for commit 568a822. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will save the government thousands of dollars... because the failure to detect was causing pager calls.
Please Note: We need to document the change in behaviour... with this patch, sr3 sanity will not longer start up "stopped" configs... only "missing" ones. That's what we decided was least astonishing... but it is still a change from how it worked before. |
close #927 |
I think the documentation always said what it was supposed to do. "sanity: looks for instances which have crashed or gotten stuck and restarts them." https://metpx.github.io/sarracenia/Reference/sr3.1.html |
I grepped for sanity and couldn't find anywhere (in English) that said it started stopped instances, only crashed or stuck instances. |
I updated HOWTO/UPGRADING.rst ... to indicate the change in behaviour. same in french ... committed direct to development. |
We had a group debugging session and fixed this issue.