Build Unit test boilerplate #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to rename flowcb/accept/delete_test.py becase there's on here too.
authenticate, destfn, download, filter, gather
…nstead There's also some test renames as well for cases where there's duplicate module names in different folders. They're now "<moduleName>__<ParentFolder>_test.py" Also removed un-neccessary imports from the boilerplate test files
Includes: accept, housekeeping, post, scheduled, send Rename conflicting modules from other flowcb folders
Test Results220 tests 212 ✅ 17s ⏱️ Results for commit b0728af. ♻️ This comment has been updated with latest results. |
|
You didn't ask for any reviewers... (top-right?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a ton of files, most of which are empty, containing no tests.
They're just there to setup the ground-work for future tests.
I also centralized the "debug" stuff into the
conftest.pyfile in the root of the tests directory. Now when looking to debug anything during test writing, you can just calldebug.pretty(YourThingToDebug), and it should work.It's also possible to centralize some fixtures there if needed. Things like building a base config, or messages could be put there, and used by all tests.
You can also create a
conftest.pyfile in any given directory, and have those contents be available in that context, either building on those defined above it, or over-riding them.Some of that is outlined here