-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding new_pathWrite() as per Reid suggestion #1049
Conversation
Test Results244 tests 235 ✅ 17s ⏱️ For more details on these failures, see this check. Results for commit c5a8d8b. ♻️ This comment has been updated with latest results. |
@reidsunderland worry:
what is a good behaviour?
For converter plugins in general, all the options feel weird...
This is essentially re-inventing the discussion in #494... and we the hierarchy makes sense again... for now, conclusion is to use flow/cvt_ to represent transformers. Also need to set msg['size'] = len(data) |
last commit included "size" support as well. so I guess it's good to go. |
I'm still puzzled as to why I haven't figured out how to leverage Transfer classes for this stuff, or have code from transfer moved here... or... Transfer/_init_.py there is read_writelocal which is exactly the same logic... but a bit more complete. |
I worked on this last week and got distracted by ddsr-dev replacing the gswob feed to the datamart. This is kind of the complement to getContent() that is used to write local files and return a well-formed message for it.
It should be helpful in callbacks that transform data. I don't know when I will get back to this either.