-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To convert, one must wololo #1045
Conversation
To convert, one must [wololo](https://knowyourmeme.com/memes/wololo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logging
should be logger
Test Results220 tests 212 ✅ 16s ⏱️ Results for commit 1b2e374. ♻️ This comment has been updated with latest results. |
Lol, copy pasta from further down the file has failed me? xD |
Omg lol |
Priority not high enough |
fwiw... logging will work, but it will use a different logger. that's why the original error isn't caught. it's not invalid... merely wrong. |
Looking at the patch it's right after telling us ''converted config exists... federal off" |
or just make wololo a synonym of convert. |
Lol, I love the option to convert a config in place via I'll spend some time looking into implementing that |
fwiw... implementation guide:
so... it's less than 10 lines... then have to add an explanation in the docs. That's just the first option... aka only overwrite an existing option if --wololo is given. |
uh... I decided to work on it... it's finished.. writing it up in an issue. |
see #1054 |
To convert, one must wololo