updatePaths work without being supplied new_dir and new_path #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 30, 2024 15:52
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann,
andreleblanc11 and
mshak2
Test Results209 tests 200 ✅ 15s ⏱️ For more details on these failures, see this check. Results for commit 7e88440. |
reidsunderland
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For @reidsunderland and @petersilva , this routine in the sarracenia.Message class does not satisfy the Princple of Least Astonishment. If you have a python method that has =None for a value... you should be able to omit it.
looking through the code, it is clear that the code will crash if either one or both of new_dir and new_file arguments are omitted. in all places in the existing code, both args are supplied.
However to make it nicer to use for plugin writers, added logic to infer the correct values from existing message fields whenever possible.