Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flakey flow test failing when polls killed with -9 cannot remove novip state file #1032

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

petersilva
Copy link
Contributor

so... set had_vip the previous state based on the presence/absence of the novip file.
so it it does have the vip... it triggers the transition to remove it.

This is the reason flakey flow test suite are failing with two polls in wvip sometimes...

this is the test that fails, usually with both sftp polls being in wVip state.


test 36 success: there should be 1 process in wVip state

The real cause is that the vip flipped, but since it already had the vip (default true..)
it doesn't remove the novip file.

Copy link

Test Results

209 tests   201 ✅  16s ⏱️
  1 suites    8 💤
  1 files      0 ❌

Results for commit 1157e13.

@petersilva
Copy link
Contributor Author

unit tests always fail because coverage is so low that the list of what is not covered is too big.
I've talked to Greg... he is supposed to fix that.

@petersilva petersilva marked this pull request as ready for review April 30, 2024 20:17
@petersilva petersilva merged commit 37a59a6 into development Apr 30, 2024
22 of 35 checks passed
@petersilva petersilva deleted the fix_wVip_in_flaky branch May 7, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants