Azure transfer driver #1019
Azure transfer driver #1019
Conversation
Many of the test are being skipped, because there's no good/easy way to mock/fake the Azure platform.
Fix incorrect variables and methods that came from the S3 tests
Forgot to include 'azure-storage-blob'..
- Remove Matrix, only run on Ubuntu 22.04 - Publish coverage and test results - Bump checkout and upload-artifact to latest
Test Results209 tests 201 ✅ 14s ⏱️ Results for commit 3b294ce. |
|
Huh.. I didn't mean to merge this so quickly, but... great! |
|
commit early-commit often... the gethttps thing... will it provide the proper authentication? |
❤️
No. It's just giving the URL to the file in question. The assumption would be that the publisher would have anonymous access turned on for the account/container in question, so SAS tokens wouldn't be required. If auth was needed, the consumer could just use the Azure transfer driver, which does accept credentials. Happy to change that if you want, but the creds returned will be those of the publisher, so... that might not be ideal. Unless we add a config option for "publish" creds that the driver uses when it returns the HTTPs URL. |
|
fair point... forget it for now. |
Draft
This implements an Azure transfer driver, to complement the S3 one from #1010.