Transfer documentation and a fix for all tests... #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann,
andreleblanc11 and
mshak2
reidsunderland
approved these changes
Apr 4, 2024
|
Seem like adding the type hints broke unit testing on Ubuntu 20.04, as it hasn't worked there since this was merged. |
gcglinton
added a commit
that referenced
this pull request
Apr 5, 2024
|
yeah... trying to figure out why the tests broke because we added type hints. that routine is weird... it's polymorphic... returning different types depending on the protocol... but that is really what is needed... it's not wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after working with @gcglinton, @reidsunderland, @andreleblanc11 on the new s3 transfer class, I added some documentation about how to write transfer classes. The principle unfathomable part is what the ls() entry point returns, which is quite odd. It is the right thing to do, but it requires explanation, included in the commits.
Also noticed that after AM protocol work with @andreleblanc11 the cleanup() function of the retry class was crashing many tests. Have to add some initialization to get the cleanup to work.