Remove buffer_factor_size setting from canned iodef.xml files#408
Open
Ed Hone (EdHone) wants to merge 2 commits into
Open
Remove buffer_factor_size setting from canned iodef.xml files#408Ed Hone (EdHone) wants to merge 2 commits into
Ed Hone (EdHone) wants to merge 2 commits into
Conversation
Mike Hobson (mike-hobson)
approved these changes
Jun 16, 2026
Mike Hobson (mike-hobson)
left a comment
Contributor
There was a problem hiding this comment.
If it doesn't need to be there and it's wrong, anyway, then I'm happy for it to be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: svadams (@svadams)
This change removes a mis-spelled keyword setting from iodef.xml files in the canned
exampledirectories. The setting does not need to be there and the mis-spelling causes issue for XIOS3 compatibility.Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - lfric_core-rm-bufferfactorsize/run2
Suite Information
Task Information
✅ succeeded tasks - 422
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review