Skip to content

Update release script to cope with JULES shared metadata #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025

Conversation

jennyhickson
Copy link
Contributor

@jennyhickson jennyhickson commented Jul 9, 2025

Description

Summary

JULES shared metadata doesn't contain any macros (these are handled seperately) so wants excluding from most of the LFRIc Apps release processes. It does still need to have a copy of the HEAD metadata at the release version.

Changes

  • Change find_meta_dirs() to be more generic, passing in the exclude list seperately.
  • Using find_meta_dirs() to seperately create a set of jules shared metadata directories from the rest and create a combined set of jules shared metadirs and the rest of the metadirs
  • Use the combined set for copy_head_meta() only.

Checklist

  • I have performed a self-review of my own changes

@jennyhickson jennyhickson requested a review from a team as a code owner July 9, 2025 14:31
@jennyhickson jennyhickson requested review from Pierre-siddall and removed request for a team July 9, 2025 14:31
Copy link
Contributor

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion

Copy link
Contributor

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good

Copy link
Contributor

@Pierre-siddall Pierre-siddall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go to me, well done Jenny merging to main now.

@Pierre-siddall Pierre-siddall merged commit c10c876 into main Jul 14, 2025
19 checks passed
@Pierre-siddall Pierre-siddall deleted the fix_release branch July 14, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants