don't copy in versionXX_YY imports #93
Conversation
james-bruten-mo
requested review from
cameronbateman-mo,
jennyhickson,
mo-nikosbaltas and
t00sa
and removed request for
a team,
cameronbateman-mo and
mo-nikosbaltas
|
After discussion with Jenny, we've decided we're missing a feature in apply_macros which is required for new metadata sections. I'll "take" this PR back and do that work here. |
|
@jennyhickson and @t00sa I think this is ready to be looked at. Cheers |
jennyhickson
left a comment
jennyhickson
left a comment
There was a problem hiding this comment.
Seems generally sound - with further algorithmic improvements in the pipeline as discussed.
|
Thanks Jenny, modifications made based on your comments, plus the addition of ordering the meta_dirs as discussed offline |
|
Thanks Jenny, modifications as per your comments. Also the addition of ordering the meta_dirs as discussed offline |
jennyhickson
left a comment
jennyhickson
left a comment
There was a problem hiding this comment.
Thanks. Think I'm happy. Over to Sam to take a look.
t00sa
left a comment
t00sa
left a comment
There was a problem hiding this comment.
Looks good. I've got a couple of minor suggestions and style suggestions
Co-authored-by: Sam Clarke-Green <[email protected]>
Co-authored-by: Sam Clarke-Green <[email protected]>
Description
When a new metadata section with rose app is added, at commit to trunk the app needs to be updated to the latest metadata. This means any imported metadata macros need to be applied to the app and so they need to be copied into the new versions.py by apply_macros. This change adds that functionality.
I've tested this against the new Jules app to ensure it works. I've also checked normal macros work as they currently do. The new functions should get a unit test, but I've not yet added this. I'll open a new issue to add these, and to setup the unit tests to run as CI.
I'm not convinced that the combine_missing_macros function will work perfectly in more complex cases where there are multiple metadata imports. However it is ok for now and will unblock some existing apps tickets.
Checklist