-
Notifications
You must be signed in to change notification settings - Fork 2
Delete xc40 and spice #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Yaswant Pradhan <[email protected]>
This ticket should wait until the UM, Jules, Apps and UKCA related tickets are on. I'll update again once that's done. |
…ts into delete_xc40_spice
All the relevant sub-tickets are now on (Core and Mule are waiting but aren't needed for this) so this ticket is ready for review and commit. Cheers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to be merged as it mostly concerns the removal of xcs and spice conditional blocks and then re-tweaks the suites which are run by the nightly testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A couple of preexisting typographical errors:
suite_report.py
L263:264 preffered -> preferred
L406: heirarchical -> hierarchical
My other comments about removing hard-coded path can be addressed in a separate PR
Thanks Yash, I've updated all of those, including the paths. Cheers |
Description
Summary
Remove references to the xc40s and spice from SimSys_Scripts. This is primarily changes for the kgo_install scripts, but there are a few other references.
The example nightly configs file is just there as an example so doesn't technically need changing, but the current config file has been copied in for neatness.
Checklist