Skip to content

Delete xc40 and spice #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 12, 2025
Merged

Delete xc40 and spice #78

merged 9 commits into from
May 12, 2025

Conversation

james-bruten-mo
Copy link
Contributor

@james-bruten-mo james-bruten-mo commented Apr 15, 2025

Description

Summary

Remove references to the xc40s and spice from SimSys_Scripts. This is primarily changes for the kgo_install scripts, but there are a few other references.
The example nightly configs file is just there as an example so doesn't technically need changing, but the current config file has been copied in for neatness.

Checklist

@james-bruten-mo james-bruten-mo requested a review from a team as a code owner April 15, 2025 12:17
@james-bruten-mo james-bruten-mo requested review from ericaneininger and cameronbateman-mo and removed request for a team, ericaneininger and cameronbateman-mo April 15, 2025 12:17
@james-bruten-mo
Copy link
Contributor Author

This ticket should wait until the UM, Jules, Apps and UKCA related tickets are on. I'll update again once that's done.

@yaswant yaswant added the blocked See Description for blocking PR label Apr 24, 2025
@james-bruten-mo james-bruten-mo removed the blocked See Description for blocking PR label May 8, 2025
@james-bruten-mo
Copy link
Contributor Author

All the relevant sub-tickets are now on (Core and Mule are waiting but aren't needed for this) so this ticket is ready for review and commit. Cheers

Copy link
Contributor

@Pierre-siddall Pierre-siddall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to be merged as it mostly concerns the removal of xcs and spice conditional blocks and then re-tweaks the suites which are run by the nightly testing.

Copy link
Contributor

@yaswant yaswant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple of preexisting typographical errors:

suite_report.py
L263:264 preffered -> preferred
L406: heirarchical -> hierarchical

My other comments about removing hard-coded path can be addressed in a separate PR

@james-bruten-mo
Copy link
Contributor Author

Thanks Yash, I've updated all of those, including the paths. Cheers

@james-bruten-mo james-bruten-mo requested a review from yaswant May 12, 2025 09:49
@yaswant yaswant merged commit 790d9f3 into main May 12, 2025
19 checks passed
@yaswant yaswant deleted the delete_xc40_spice branch May 12, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants