chore(ui): a11y skip-link, useMemo, hook fixes, dead-code cleanup#249
Merged
Conversation
Small UI/hook cleanup that fell out of the audit:
- overall-layout: add skip-link + main-content anchor; aria-label on the
main form. Trims unused legacy nav code.
- transaction-card: useMemo the JSON.parse(transaction.txJson) so the
parse only runs when txJson changes, not on every render. Removes a
dead `import { get } from \"http\"` that was sneaking into the client
bundle.
- signable-card: defensive parse for legacy payload shapes.
- card-show-signers, signing/index: small render fixes.
- ImgDragAndDrop, MeshProviderClient, BotManagementCard, background.tsx:
drop dead state vars / unused imports surfaced by the audit.
- useAppWallet, useMultisigWallet: stable returns; missing-wallet path
no longer spins indefinitely.
- Delete `src/components/multisig/proxy/ProxyControlExample.tsx`. It was
example-only code, not exported from the proxy index, never rendered
anywhere. The barrel import is updated.
Test plan
- 165/165 staged-suite tests pass on top of #237
- Typecheck clean
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-opening as new PR — original #239 was auto-closed when its base branch (
feat/server-hardening-and-audit-log) was deleted on merge of #237. Same diff, now targetingmain.UI hygiene: a11y skip-link, JSON.parse memoization in transaction-card, hook dependency fixes, removal of dead example component (107 lines) and orphan client-bundle imports.
See original #239 for full discussion.
Test plan
ProxyControlExample) is fully removed🤖 Generated with Claude Code