test(sdk): add some basic E2E tests with test.mermaidchart.com
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a basic E2E test with https://test.mermaidchart.com
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
sidharthv96
changed the base branch from
fix/fix-handleAuthorizationResponse-missing-state-in-url
to
main
sidharthv96
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR: This PR is stacked on top of:
#handleAuthorizationResponse()#5.Please change this PR to target
mainonce #5 has been merged.In PR #5 I added some unit tests for the
@mermaidchart/sdkpackage that mock communication so it works offline. However, if we really want to test if our API works, we need to have proper E2E tests with a real server.I've added a basic E2E test with that is run with
pnpm run test:e2eon https://test.mermaidchart.com/. These E2E tests are not run when doingpnpm test, since they're slower and need an API key.For GitHub Actions, I've set up an API Key for a new user I created on https://test.mermaidchart.com/ called
[email protected].