feat: Add requestTimeout to avoid long running queries #26
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
A hard-coded 5 second timeout seems a bit short for me, especially if there's no way to change this.
I've often programmed on trains/cellular connections, and it's entirely possible I might lose internet connection for a few seconds.
I think we need a parameter option for this, with a larger default timeout. ky uses 10 seconds as a default, so maybe we can use that too? https://github.com/sindresorhus/ky/blob/cac5fbd2f79de2339eb3b3d084d521d3e5d4c0bc/source/core/Ky.ts#L144
This would also be a breaking change, but d536be5 is unreleased and is a breaking change anyway, so that's not too big of a deal.
Co-authored-by: Alois Klink <[email protected]>
There was a problem hiding this comment.
LGTM! Thanks for those changes.
One last thing before merging, can you add an entry to the CHANGELOG.md under the [UNRELEASED] section, e.g. something like:
## [UNRELEASED]
### Changes
- Set a 30 second default timeout for all requests
### Added
- Added `requestTimeout` option to configure timeout.
After that, feel free to merge whenever!
Without timeout, if a network error occurs, it takes ~15 minutes to throw an error.