Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): publish @mermaidchart/cli v0.1.0 #24

Merged
merged 2 commits into from
Apr 22, 2024
Merged

chore(cli): publish @mermaidchart/cli v0.1.0 #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bbba0c
fix(cli): add title for linking MD diagrams
aloisklink Apr 22, 2024
80aac64
chore(cli): publish @mermaidchart/cli v0.1.0
aloisklink Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Changelog

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

## [0.1.0] - 2024-04-22

Initial release.
6 changes: 2 additions & 4 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
{
"name": "@mermaidchart/cli",
"version": "0.1.0-alpha.0",
"version": "0.1.0",
"description": "CLI for interacting with https://MermaidChart.com, the platform that makes collaborating with Mermaid diagrams easy",
"main": "index.js",
"bin": {
"mermaid-chart": "dist/cli.js"
},
"//1": "temporarily disable pushing until we finish progress on this",
"private": true,
"engines": {
"node": "^18.18.0 || ^20.0.0"
},
Expand Down Expand Up @@ -57,7 +55,7 @@
"@inquirer/confirm": "^2.0.15",
"@inquirer/input": "^1.2.14",
"@inquirer/select": "^1.3.1",
"@mermaidchart/sdk": "workspace:^",
"@mermaidchart/sdk": "^0.2.1-alpha.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change this? Pnpm release will automatically put the correct version right?

Copy link
Contributor Author

@aloisklink aloisklink Apr 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change this? Pnpm release will automatically put the correct version right?

Yep, but npm publish won't. And the workspace:^ breaks with things like https://gitpkg.vercel.app, which makes testing things in git subfolders more difficult.

It sounds like it also doesn't work with PNPM v9's new built-in install from a git subfolder feature, unfortunately: pnpm/pnpm#7487 (comment)

"commander": "^11.1.0",
"remark": "^15.0.1",
"remark-frontmatter": "^5.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/remark.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export function plugin({ client, ...options }: MCPluginOptions) {
case 'link':
node.value = await link(node.value, client, {
cache: options.cache,
title: ``,
title, // TODO: should we update this title in the future, since the filename/line number might change
getProjectId: options.getProjectId,
ignoreAlreadyLinked: true,
});
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mermaidchart/sdk",
"version": "0.2.0",
"version": "0.2.1-alpha.0",
"description": "Access the MermaidChart services with OAuth and type safety.",
"browser": "dist/bundle.iife.js",
"types": "dist/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading