build(sdk): Add ESLint/prettier for the @mermaidchart/sdk library

[aloisklink]

📖 Description

This PR adds a pnpm run lint and pnpm run lint:fix rule to the packages/sdk folder that runs ESLint and Prettier. I've also setup CI to run linting automatically, but only for the packages/sdk subfolder, since I don't want to cause merge conflicts with anything @jgreywolf is working on in packages/office.

I've also fixed all of the ESLint and Prettier errors in the SDK (although most of them were from my recent PRs!).

There are no functionality changes to the code, it's all just formatting changes.

✍️ Type of Change

• DevOps change
• Style changes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
office-plugin-site	⬜️ Ignored (Inspect)	Visit Preview		Apr 22, 2024 5:57am

[aloisklink]

@sidharthv96, this.resetAccessToken() here returns a Promise, but we're not await-ing on it. This looks okay to me, but is this expected behaviour?

It looks like this.resetAccessToken() in packages/office/src/lib/mermaidChartApi.ts doesn't return a Promise, so maybe it's a bug:

plugins/packages/office/src/lib/mermaidChartApi.ts

Line 204 in 1ddbb2c

public resetAccessToken() {

plugins/packages/sdk/src/index.ts

Line 150 in 1ddbb2c

public async resetAccessToken(): Promise<void> {

[jgreywolf]

Because it was not awaited, and if memory serves is being called from a non-async function, I removed the Promise expectation from the office version

[sidharthv96]

You can remove async from resetAccessToken. The implementation doesn't require it.

[aloisklink]

Fixed by 203aabc

I was reluctant to make this change, since changing a function to/from async is a breaking change, but 🤷, I think other than Mermaid-Chart/vscode-mermaid-chart#6, nobody is using the @mermaidchart/sdk library. Plus, it will be easy for us to bump the version to ^0.2.0.