Merge pull request #6 from Mermaid-Chart/fix/fix-handleAuthorizationR…

…esponse-missing-state-in-url fix(sdk): fix `#getAuthorizationData()` default URL missing a `state` parameter
Mermaid-Chart · Nov 24, 2023 · 654d323 · 654d323
2 parents 838d435 + 6dc3248
commit 654d323
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/packages/sdk/CHANGELOG.md b/packages/sdk/CHANGELOG.md
@@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- `MermaidChart#getAuthorizationData()` now correctly sets `state` in the URL
+  by default.
 - `MermaidChart#handleAuthorizationResponse()` now supports relative URLs.
 
 ## [0.1.1] - 2023-09-08

diff --git a/packages/sdk/src/index.test.ts b/packages/sdk/src/index.test.ts
@@ -39,6 +39,14 @@ describe('MermaidChart', () => {
     });
   });
 
+  describe('#getAuthorizationData', () => {
+    it('should set default state', async () => {
+      const { state, url } = await client.getAuthorizationData();
+
+      expect(new URL(url).searchParams.has('state', state)).toBeTruthy();
+    });
+  });
+
   describe('#handleAuthorizationResponse', () => {
     let state: AuthorizationData['state'];
     beforeEach(async () => {

diff --git a/packages/sdk/src/index.ts b/packages/sdk/src/index.ts
@@ -83,7 +83,7 @@ export class MermaidChart {
 
     const url = await this.oauth.authorizationCode.getAuthorizeUri({
       redirectUri: this.redirectURI,
-      state,
+      state: stateID,
       codeVerifier,
       scope,
     });