Update SorterBlockHandlers.cs #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removal of `using IngameScript.Program` Whilst ignored by MDK1, it breaks compilation under MDK2 and Malware said to remove it
|
You tested that the program (and sorter block) still function correctly with this import removed? |
|
Is there a link to that discussion, maybe on Discord? |
|
I'll check for a link to the discussion. would be several days back now, and with Malware himself, as he walked me through trying to convert the codebase over to MDK2 from MDK1. in the end, I just... kinda walked through the MDK2 stuff, threw the code in there, had it blow up on this file, and Malware said it wasn't needed anymore and to remove it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removal of
using IngameScript.ProgramWhilst ignored by MDK1, it breaks compilation under MDK2 and Malware said to remove it