Fixed #4 - avoid generating empty fields in JSON outputs #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot displaying an empty field when the corresponding flag was not specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about not displaying a certain field (country, city, asn, etc.) in the JSON output when the corresponding flag was not present. This was done by using the feature of pointers such that, when the pointers are written to a JSON file, they will be ignored if they have a value of
nil. Otherwise, the field key will be created, and the value will be written into the entry.This modification aims to improve the readability of the output and reduce the cost of uploading JSON files to BigQuery.