Markzz/v6 64s #10
Open
Markzz/v6 64s #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an IP-in-IP packet (protocol 4) is encountered, this will force it to be classified as an Unknown packet.
On the branch sebjin/v6, no care was taken to make the msgp system handle encoding/decoding a state file. The fixes are as follows: 1. Change logic in Cache.load() to reinclude a loop for multiple objects in file. 2. Adds a field in the cache header to mark whether a file is IPv6 or not. 3. Adds new type IPv6Addr that implements msgp.Extension. 4. Regenerate all msgp generated files (which was not done).
Some fixes applied: 1. Fixed output of destination IP count. 2. Fixed output of unique destination /64s (labelled as /24s, maybe to be fixed later). 3. Changed up how IPv6 addresses for destinations are stored (new IPv6AddrSet type). 4. Regenerated msgp files with above changes.
added 5 commits
June 8, 2022 16:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix most of our woes with IPv6 processing.