Skip to content

Conversation

@sileht
Copy link
Member

@sileht sileht commented Oct 16, 2025

This adds the monorepo section and talk about scopes

Copilot AI review requested due to automatic review settings October 16, 2025 12:38
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 16, 2025 12:38 Failure
@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = build
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = mergify-ci-bot

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= .{48,}

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new documentation page detailing scope-based optimization for monorepos and links it in the Merge Queue navigation.

  • Adds a "Monorepo Optimization" doc with configuration and CI examples
  • Updates navigation to include the new page under Merge Queue

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.

File Description
src/content/navItems.tsx Adds nav item linking to the new Monorepo Optimization docs page
src/content/docs/merge-queue/monorepo.mdx Introduces comprehensive docs on scopes with YAML and GitHub Actions examples

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sileht sileht force-pushed the devs/sileht/mergify-ci-mono-repo/I7a91bbdad01645bbd849da5b892e20c64791a85a branch from aa91118 to 1fbc3ef Compare October 16, 2025 12:57
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 16, 2025 12:57 Failure
@mergify mergify bot requested a review from a team October 16, 2025 12:59
@sileht sileht force-pushed the devs/sileht/mergify-ci-mono-repo/I7a91bbdad01645bbd849da5b892e20c64791a85a branch from 1fbc3ef to 1bb429b Compare October 16, 2025 12:59
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 16, 2025 12:59 Failure
jd
jd previously requested changes Oct 16, 2025
Copy link
Member

@jd jd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice with some schema too but maybe later.

@sileht sileht force-pushed the devs/sileht/mergify-ci-mono-repo/I7a91bbdad01645bbd849da5b892e20c64791a85a branch from 1bb429b to 7e7a3dc Compare October 17, 2025 07:02
@mergify mergify bot dismissed jd’s stale review October 17, 2025 07:03

Pull request has been modified.

@mergify mergify bot had a problem deploying to Mergify Merge Protections October 17, 2025 07:03 Failure
@mergify mergify bot requested a review from a team October 17, 2025 07:06
@sileht sileht force-pushed the devs/sileht/mergify-ci-mono-repo/I7a91bbdad01645bbd849da5b892e20c64791a85a branch from 7e7a3dc to a6ea007 Compare October 17, 2025 07:07
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 17, 2025 07:08 Failure
remyduthu
remyduthu previously approved these changes Oct 17, 2025
@sileht sileht force-pushed the devs/sileht/mergify-ci-mono-repo/I7a91bbdad01645bbd849da5b892e20c64791a85a branch from a6ea007 to e75e242 Compare October 17, 2025 13:04
@mergify mergify bot dismissed remyduthu’s stale review October 17, 2025 13:05

Pull request has been modified.

@mergify mergify bot had a problem deploying to Mergify Merge Protections October 17, 2025 13:05 Failure
@mergify mergify bot requested a review from a team October 17, 2025 13:07
JulianMaurin
JulianMaurin previously approved these changes Oct 20, 2025
Copy link
Contributor

@JulianMaurin JulianMaurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice 🙌

But I think the complexity related to the merge-queue scope can lead to confusion.
Maybe it's a dumb suggestion, but if it only applies to draft PRs, maybe we can set a name that reflects this better

@mergify mergify bot dismissed JulianMaurin’s stale review October 20, 2025 09:42

Pull request has been modified.

@mergify mergify bot had a problem deploying to Mergify Merge Protections October 20, 2025 09:42 Failure
@mergify mergify bot requested a review from a team October 20, 2025 09:50
jd
jd previously requested changes Oct 20, 2025
Copy link
Member

@jd jd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing entry in index pages too.

@sileht sileht force-pushed the devs/sileht/mergify-ci-mono-repo/I7a91bbdad01645bbd849da5b892e20c64791a85a branch from 20e1d82 to 7289995 Compare October 20, 2025 11:13
@mergify mergify bot dismissed jd’s stale review October 20, 2025 11:13

Pull request has been modified.

@mergify mergify bot had a problem deploying to Mergify Merge Protections October 20, 2025 11:13 Failure
@sileht sileht force-pushed the devs/sileht/mergify-ci-mono-repo/I7a91bbdad01645bbd849da5b892e20c64791a85a branch from 7289995 to c0022d9 Compare October 20, 2025 12:08
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 20, 2025 12:09 Failure
@sileht sileht force-pushed the devs/sileht/mergify-ci-mono-repo/I7a91bbdad01645bbd849da5b892e20c64791a85a branch from c0022d9 to 57e546a Compare October 20, 2025 12:10
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 20, 2025 12:10 Failure
Change-Id: I7a91bbdad01645bbd849da5b892e20c64791a85a
@sileht sileht force-pushed the devs/sileht/mergify-ci-mono-repo/I7a91bbdad01645bbd849da5b892e20c64791a85a branch from 57e546a to 0e461ae Compare October 20, 2025 13:08
@mergify mergify bot deployed to Mergify Merge Protections October 20, 2025 13:09 Active
@mergify mergify bot requested a review from a team October 20, 2025 13:10
@sileht sileht requested a review from jd October 20, 2025 14:26
@mergify mergify bot added the queued label Oct 21, 2025
mergify bot added a commit that referenced this pull request Oct 21, 2025
@mergify mergify bot merged commit 4481b82 into main Oct 21, 2025
9 checks passed
@mergify mergify bot deleted the devs/sileht/mergify-ci-mono-repo/I7a91bbdad01645bbd849da5b892e20c64791a85a branch October 21, 2025 14:09
@mergify mergify bot removed the queued label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants