-
Notifications
You must be signed in to change notification settings - Fork 10
feat: add documentation about scope #9077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add documentation about scope #9077
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new documentation page detailing scope-based optimization for monorepos and links it in the Merge Queue navigation.
- Adds a "Monorepo Optimization" doc with configuration and CI examples
- Updates navigation to include the new page under Merge Queue
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| src/content/navItems.tsx | Adds nav item linking to the new Monorepo Optimization docs page |
| src/content/docs/merge-queue/monorepo.mdx | Introduces comprehensive docs on scopes with YAML and GitHub Actions examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aa91118 to
1fbc3ef
Compare
1fbc3ef to
1bb429b
Compare
jd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice with some schema too but maybe later.
1bb429b to
7e7a3dc
Compare
7e7a3dc to
a6ea007
Compare
a6ea007 to
e75e242
Compare
Pull request has been modified.
JulianMaurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's nice 🙌
But I think the complexity related to the merge-queue scope can lead to confusion.
Maybe it's a dumb suggestion, but if it only applies to draft PRs, maybe we can set a name that reflects this better
Pull request has been modified.
jd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing entry in index pages too.
20e1d82 to
7289995
Compare
7289995 to
c0022d9
Compare
c0022d9 to
57e546a
Compare
Change-Id: I7a91bbdad01645bbd849da5b892e20c64791a85a
57e546a to
0e461ae
Compare
This adds the monorepo section and talk about scopes